Skip to content

Alerting: Add acknowledge handling improvements

Jochen Kressinrequested to merge
alerting-improvements into main-os

This relates to issue #8 (closed)

Description of changes

This MR adds the improvements for acknowledging actions, including:

  • Unacknowledgeable actions
  • Landing page for acknowledging actions
  • Watch overview page: URL parameter control

Corresponding commits:

  • Deeplink for acknowledging actions
  • Watch overview page: preserve filters; deeplinks for filters
  • Signals Watches overview: Handle ack_enabled

APIs

See comment in Issue #8 (closed); the following needs to be taken into consideration for the backend:

This endpoint also needs to be adapted then: https://git.eliatra.com/eliatra-suite/eliatra-opensearch-plugin/-/blob/main/alerting-core/src/main/java/com/eliatra/suite/alertingplus/execution/WatchExecutionContext.java#L116

Impact assessment

Breaking changes

  • No
  • Yes (described in Description section above)

Risk of regressions

  • Low
  • High

Performance impact

  • None
  • Low
  • Medium: «please describe»
  • High: «please describe»

New dependencies

  • No
  • Yes: «please describe»

User experience impact

  • None
  • Low: This MR introduces a new feature but does not affect existing ones in a huge way
  • Medium
  • High

Checklist

  • Changes are tested
  • Changes are documented in the MR description (since this is a port of existing changes)
  • Impact assessment is done
  • Newly introduced dependencies are reviewed
  • Spotless was executed
  • Review was performed

Merge request reports